[Javascript] syntax

Jens Brueckmann jens.brueckmann at gmail.com
Fri Oct 12 07:46:52 CDT 2007


> Hmmm... if i do this:
> href=\'onmousedown=\'document.getElementById(\'TestL\').style.visibility
> =\'hidden\'\'\'
> I get onmousedown= not found...

I think the first step in improving your enigmatic code is separating
the "outer" and "inner" event handler by allocating a function to the
"outer" handler. Something like this:

<script type="text/javascript">
function toggle()
	{

	var TestL = document.getElementById("TestL");
	TestL.style.visibility='visible';

	var elem1 = "<div style='left:10%;width: 200px; position:absolute;
font-size:20px;'>Test</div>";
	var elem2 = "<div style='top:35px; left:1%; position: absolute;'><img
src='test1.jpg'></div>";
	var elem3 = "<div style='right:18%; top: 0px; right:60px;width:
100px; position:absolute; font-size:20px;'>Test</div>";
	var elem4 = "<div style='right:1%; position: absolute;
top:35px;'><img src='test2.jpg\' width='300px'></div>";
	var elem5 = "<div style='right:1%; top: 260px; width:
220px;position:absolute; font-size:20px;'>Test</div>";
	var elem6 = "<div style='right:2%;top:298px; position:
absolute;'><img src='test3.jpg' width='200px'></div>";
	var elem7 = "<div style='left:360px; top:40px; position:absolute;'
align='left'><u>Text</u><br><br><ul><li>text1</li><li>text2</li></ul></div>";
	var elem8 = "<div style='top:370px; width: 60px;  left: 45%;position:
absolute;'>";
	var elem9 = "<a onmousedown='var TestL =
document.getElementById(\"TestL\");TestL.style.visibility=\"hidden\"'><center>Close</center></a></div>";

	TestL.innerHTML=elem1 + elem2 + elem3 + elem4 + elem5 + elem6 + elem7
+ elem8 + elem9;

	}
</script>

and calling this function by:

<a onmousedown="toggle()">click</a>

There is room for still lots of improvement, but this is a first step
in separating content and behaviour.

Cheers,

jens

-- 
Jens Brueckmann
http://www.yalf.de



More information about the Javascript mailing list