[thelist] why does this javascript cause errors

Ornstein, Ian IanOrnstein at NC.SLR.com
Fri Oct 26 07:50:14 CDT 2001


Don't you just love when the programmer uses single letter varable names?
It seems there is also a shortage of new line characters
here that would improve reability.

Next time, insist on a code review.

Ian Ornstein - Programmer and Web Developer
IBM Global Services, Global AMS Delivery
(704) 509-8022 


-----Original Message-----
From: Meredith Tupper [mailto:meredith at pintsize.com]
Sent: Thursday, October 25, 2001 6:46 PM
To: thelist at lists.evolt.org
Subject: [thelist] why does this javascript cause errors


Hi folks, sorry if this is too simple but I could use some
debugging help...I'm working on a site that I didn't create;
it had a popup window for an event.  I am trying to remove
the popup window now by deleting code that looks like it's
related to the popup window.  I have succeeded in removing
it but now the page loads with errors.  When it comes to
javascript, I represent a hazard to myself and others.  Any
assistance would be ever so appreciated.  Here's the code:

<script language="JavaScript">


function MM_swapImgRestore() { //v3.0
  var i,x,a=document.MM_sr;
for(i=0;a&&i<a.length&&(x=a[i])&&x.oSrc;i++) x.src=x.oSrc;
}

function MM_preloadImages() { //v3.0
  var d=document; if(d.images){ if(!d.MM_p) d.MM_p=new
Array();
    var i,j=d.MM_p.length,a=MM_preloadImages.arguments;
for(i=0; i<a.length; i++)
    if (a[i].indexOf("#")!=0){ d.MM_p[j]=new Image;
d.MM_p[j++].src=a[i];}}
}

function MM_findObj(n, d) { //v3.0
  var p,i,x;  if(!d) d=document;
if((p=n.indexOf("?"))>0&&parent.frames.length) {
    d=parent.frames[n.substring(p+1)].document;
n=n.substring(0,p);}
  if(!(x=d[n])&&d.all) x=d.all[n]; for
(i=0;!x&&i<d.forms.length;i++) x=d.forms[i][n];
  for(i=0;!x&&d.layers&&i<d.layers.length;i++)
x=MM_findObj(n,d.layers[i].document); return x;
}

function MM_swapImage() { //v3.0
  var i,j=0,x,a=MM_swapImage.arguments; document.MM_sr=new
Array; for(i=0;i<(a.length-2);i+=3)
   if ((x=MM_findObj(a[i]))!=null){document.MM_sr[j++]=x;
if(!x.oSrc) x.oSrc=x.src; x.src=a[i+2];}

//

</script>

The site is located here: http://www.p-grace.org.

TIA,
Meredith

<tip type=sincere>
For those who install a lot of cgi stuff, it's a good idea
to set aside a block of time when you won't be disturbed,
get a fresh cup of coffee, and then check every script
you've installed to make sure permissions are correct (no
stray 777s) and to make sure you've deleted all those "check
setup" scripts that leave scripts vulnerable to hackers.
This sounds obvious, but I've worked with this stuff for
four years now and just last week a check_setup.cgi bit me
in the butt.  It pays to catch the script before the script
catches you.
</tip>

--
PintSize Graphics & Web Hosting, Inc.
http://www.pintsize.com
meredith at pintsize.com
3225 S. MacDill Ave. #208
Tampa, FL 33629
813-835-5382






More information about the thelist mailing list