[thelist] code check

rudy r937 at interlog.com
Wed Nov 14 20:56:57 CST 2001


hi joel

<table ... width="800">

this is too wide for 800x600 screens; cut it to 728

  <td colspan="2" valign="top">
   <img src="images/logo_tagline.gif" width="344" height="116"
           border="0" alt="here and now(tm)."><br><br>
  <td valign="top">
   <img src="images/logo.gif" width="376" height="116"
          border="0" alt="magis(tm)" align="left">
   <img src="images/spacer.gif" width="8" height="20"
          border="0" alt="">

this top row should be a separate, "stacked" table on top of whatever
follows; the page will render faster, and the browser will neither have to
calculate nor risk getting confused by colspans

note that the max height of the row, based on the images in it, is 116 --
consequently, the valign="top" in the first cell is superfluous, and in the
second cell serves only to place the spacer at the top of the cell

oh, and note that the widths of the cells add up to 728, which is less than
the stated 800 of the table -- consequently, the browser has to guess which
cells get how much additional space

there may be variations in how browsers allocate the extra space, but since
the contents of the second cell are left aligned, the logo may not always
be in the same place in all browsers

oh, and you have whitespace in front of your </td>   ;o)

  <td valign="top" rowspan="2" width="300">
  <img src="images/spacer.gif" width="40" height="300" align="left"
           border="0" alt="">
   <img src="images/chipset.jpg" alt="Magis Chipset">
     <p class="main">
<span class="legal">
  &#169;2001 Magis Networks, Inc. All rights reserved.<BR>
  <img src="images/global/spacer.gif" width=1 height=7 border=0 alt=""><br>

here the valign="top" is required, if indeed that's what you want --
personally, i think valign="middle" might look better, but then you might
have to re-work the spacer shim's height

rowspan="2" is problematic (see below)

the chipset jpg should have its dimensions defined

use <p> instead of <span>

  <td width="600" colspan="3" valign="top">
   <table cellpadding="10" cellspacing="0" border="0">

okay, with the previous row having a width=300 cell that extends into this
row, how can this row's second cell be 600 and still stay within the
width=800 of the table?

and where are the 3 columns?  that'd make 4 in total, but the top row only
had 3

  <td width="600">

this row superfluous if you stack your tables

okay, a quick peek into the nested table...

   <hr size="1" class="green"><br>
   <p class="header"><strong>Magis</strong> develops [snip]<br>
   <img src="images/homecollateral.gif" [snip] ><br>
   <hr size="1" class="green">

the <br> after the <hr> is not necessary, as the hr is by default as wide
as its container, and the <p> starts a new block

the <br> in front of the image is probably not necessary, seeing as how
wide it is

get in the habit of closing your <p>'s

the <br> in front of the <hr> is not necessary

how did i do?  is that the kind of feedback on the code you wanted?


More information about the thelist mailing list