[thesite] comments on test.evolt.org

[Daniel J. Cody]

+1 for all

aardvark wrote:

> i don't think it's worth creating a new class for the +/-...
> 
> i think you should use — instead of a hyphen in the +/-...
> 
> style="cursor: hand" requires a closing semicolon...
> 
> if you're going to add a 'commentitle' class, try to mimic the 
> structure/names in the existing CSS.. or consider adjusting the 
> <h4> - <h6> styles altogether (just set them all to the same 
> color)... doesn't mean it's more correct, but it's worth thinking 
> about...
> 
> do we need new classes for the author name and time?  i don't 
> think so...
> 
> this was also supposed to be span-free, using tags only for 
> structure, and imparting style through those... there are three 
> <span>s in there i don't think we need...
> 
> class the anchor for the +/- (especially since the whole bar as an 
> expando-thingie is too much since you can't highlight text and the 
> hit area for the name is now too small compared to the rest)... 
> IOW, remove the JS event from the <td> and insert it into an <a>, 
> class that...
> 
> does the author need a style?  if you really think it does, put it in 
> the <a>... i think it should go...
> 
> i don't think the time needs one at all, the span and class should 
> go...
> 
> overall, every time we modify the page, nobody runs it through a 
> validator, and on top of that, we keep adding more and more code, 
> and everyon's got a different style... these pages take forever to 
> render on my home machine... we don't need all this code we keep 
> adding, but we keep going to town on it... and the page is now 
> peppered with <span> tags... we also need to not add classes to 
> the CSS... every time we do that, we're going to have to revisit the 
> style changer and modify all the styles that go along with it... we 
> have enough styles in there that we should be pretty good to go for 
> a long time...
> 
> doncha wish you hadn't asked?
> 
> 
>>From: "Isaac Forman" <isaac at triplezero.com.au>
>>
>>can people check this out and see what they think:
>>
>>http://test.evolt.org/article/expandomagico/21/10781/index.html
>>
>>the comment expand/collapse is a win/ie5+ only feature which jeff has
>>added.
>>
>>meanwhile, i've made the comment title black, reduced the
>>expand/collapse +/- a bit, and changed the colour and size of the
>>comment authorname.
>>
> 
> _______________________________________________
> For unsubscribe, archive, and options, go to:
> http://lists.evolt.org/mailman/listinfo/thesite
>